Fix CI bot detection based on the Julia-CI-Variables header
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation would only end up checking the first two characters of each semi-colon separated entry in the header, effectively causing CI bots to not be detected.
|
It would be good to add a test so that this doesn't regress in the future. |
|
I had indeed already added tests for the behavior. I did notice there weren't any tests for the |
|
🤦 That's on me, I completely missed that. |
fredrikekre
reviewed
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was messing about hitting the
/registriesendpoint while configuring theJulia-CI-Variablesheader and noticed that none of the values I set resulted in getting the "eager" flavor.It turns out the previous implementation would only end up checking the first two characters of each semi-colon separated entry in the header, effectively causing CI bots to not be detected.