Fix issue with .7 where 7zip extracts the file without the noarch%2F on it #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errors. I updated usage to Compat.Sys.BINDIR.
I had trouble with `escape` butchering a folderpath into a filename. I found that using a simple regex match to pick off the filename solved my problems. Don't know if other people might have had this issue as well. I'm on Windows 7 and Julia v0.7.
The `basename` function does what the previous regex match did, so use that instead.
|
Closing this as it pulling in far too much from my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #134 as well as any issue where WinRPM was failing to find the extracted cpio file from an rpm file. See #134 for a full discussion of why this was happening in .7.
This along with #136 & #139 should restore WinRPM to working condition in .7. However, the package produces a large number of warnings and a deprecation errors so this might change as .7 matures.
I am not sure if my @static if VERSION < v"0.7.0-DEV" is the proper way to fence off .7 code from .6 code. If not please let me know. I have tested this on both .7 and .6 and with this code in place files download, extract, and install successfully.
After looking this fix might be a duplicate of #137 as the problem looks the same but I did not look in depth at it.