Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yosys] enable libyoys, and several cleanups #3501

Merged
merged 3 commits into from
Aug 15, 2021
Merged

[yosys] enable libyoys, and several cleanups #3501

merged 3 commits into from
Aug 15, 2021

Conversation

sjkelly
Copy link
Contributor

@sjkelly sjkelly commented Aug 15, 2021

  • enable libyosys
  • correct version to match upstream
  • whitespace fixes
  • fix Product array

sjkelly added 2 commits August 15, 2021 11:37
@sjkelly
[yosys] enable libyoys, and several cleanups
2db1dbf 
  - enable libyosys
  - correct version to match upstream
  - whitespace fixes
  - fix Product array
@sjkelly
[yosys] fix libyosys build on apple
8555bbc
@sjkelly
Copy link
Contributor Author

sjkelly commented Aug 15, 2021

BB doesn't seem to like .so on Apple. I suppose it is safe to just rename to .dylib, or is there something I am missing here?

@sjkelly
Copy link
Contributor Author

sjkelly commented Aug 15, 2021

Relevant target: https://github.com/YosysHQ/yosys/blob/83c0f82dc842fc859dfb4b19e766b23f965cfbb3/Makefile#L681-L686

giordano
giordano reviewed Aug 15, 2021
View reviewed changes
Y/Yosys/build_tarballs.jl Outdated Show resolved Hide resolved
@giordano giordano merged commit 8660298 into JuliaPackaging:master Aug 15, 2021
@giordano giordano mentioned this pull request Aug 17, 2021
Merged
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
@sjkelly @giordano @simeonschaub
[yosys] enable libyoys, and several cleanups (JuliaPackaging#3501)
6d10032 
* [yosys] enable libyoys, and several cleanups

  - enable libyosys
  - correct version to match upstream
  - whitespace fixes
  - fix Product array

* [yosys] fix libyosys build on apple

* Update Y/Yosys/build_tarballs.jl

Co-authored-by: Mosè Giordano <[email protected]>

Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjkelly @giordano