Add MIOpen 5.2.3 #5630
Merged
Add MIOpen 5.2.3 #5630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
requested changes
Oct 4, 2022
M/MIOpen/common.jl
Outdated
| Dependency("rocBLAS_jll", version), | ||
| Dependency("Zlib_jll"), | ||
| Dependency("SQLite_jll"), | ||
| Dependency("boost_jll", v"1.79.0"), |
There was a problem hiding this comment.
Besides the specific case of boost, as a general remark, if you need a specific version of a dependency for building a package, that's a good indication that you should reflect that requirement in the compat bound. I see very little need to specify the build version without the compat, which applies also to the other dependencies above
giordano
approved these changes
Oct 5, 2022
This was referenced Oct 5, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.