Add recipe for libssh 0.10.6 #7903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Jan 4, 2024
giordano
reviewed
Jan 5, 2024
L/libssh/build_tarballs.jl
Outdated
| # Bash recipe for building across all platforms | ||
| script = raw""" | ||
| # Necessary for cmake to find openssl on Windows | ||
| if [[ ${target} == *w64* ]]; then |
There was a problem hiding this comment.
To be honest w64 is a bit obscure, I think
Suggested change
| if [[ ${target} == *w64* ]]; then | |
| if [[ ${target} == x86_64-*-mingw* ]]; then |
would be slightly clearer: the architecture and the runtime parts of the triple are clearly spelled out
There was a problem hiding this comment.
Sure, fixed in 52ccbf4.
giordano
reviewed
Jan 5, 2024
L/libssh/build_tarballs.jl
Outdated
| HostBuildDependency("Doxygen_jll"), | ||
| Dependency("Kerberos_krb5_jll"; compat="1.19.3"), | ||
| Dependency(PackageSpec(name="OpenSSL_jll", uuid="458c3c95-2e84-50aa-8efc-19380b2a3a95"); compat="3.0.8"), | ||
| Dependency(PackageSpec(name="Zlib_jll", uuid="83775a58-1f1d-513f-b197-d71354ab007a"); compat="1.2.13") |
There was a problem hiding this comment.
This won't be installable in Julia v1.6: https://github.com/JuliaLang/julia/blob/v1.6.0/stdlib/Zlib_jll/Project.toml#L3
Suggested change
| Dependency(PackageSpec(name="Zlib_jll", uuid="83775a58-1f1d-513f-b197-d71354ab007a"); compat="1.2.13") | |
| Dependency(PackageSpec(name="Zlib_jll", uuid="83775a58-1f1d-513f-b197-d71354ab007a"); compat="1.2.12") |
There was a problem hiding this comment.
Fixed in 822cc46.
|
Many thanks for the help ❤️ |
MichelJuillard
pushed a commit
to MichelJuillard/Yggdrasil
that referenced
this pull request
Jan 8, 2024
* Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6
grasph
pushed a commit
to Moelf/Yggdrasil
that referenced
this pull request
Jul 1, 2024
* Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6 * fixup! Add recipe for libssh 0.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package for https://www.libssh.org.
Some oddities:
FileProductfor the Doxygen tag file (useful when generating docs)Minimum instruction set detected for bin/libssh.dll is avx2, not x86_64 as desired. I've looked through the code to try to see where those instructions might be coming from but didn't find anything. Not sure how serious it is.