Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GtkSourceView] update to 5.10.0 #8278

Merged
merged 2 commits into from
Mar 11, 2024
Merged

[GtkSourceView] update to 5.10.0 #8278

merged 2 commits into from
Mar 11, 2024

Conversation

jwahlstrand
Copy link
Contributor

Update to v5, which depends on GTK4.

@jwahlstrand jwahlstrand mentioned this pull request Mar 11, 2024
Open
giordano
giordano reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the ABI of the package, do the packages depending on GtkSourceView fix the compat bounds correctly already?

G/GtkSourceView/build_tarballs.jl Outdated Show resolved Hide resolved
@jwahlstrand
Copy link
Contributor Author

The only package in the general registry that uses this JLL is GtkSourceWidget, and it does have compat bounds correctly set.

@giordano giordano enabled auto-merge (squash) March 11, 2024 11:33
@giordano giordano merged commit ec31226 into JuliaPackaging:master Mar 11, 2024
17 checks passed
@jwahlstrand jwahlstrand deleted the gtksourceview branch March 15, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giordano giordano giordano left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwahlstrand @giordano