pass profile parameters in JSON body #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
please can you update the PR description so the motivation / benefit is clear to anyone outside of RAI, since this is an open-source package? |
NHDaly
reviewed
May 16, 2024
NHDaly
reviewed
May 16, 2024
NHDaly
reviewed
May 16, 2024
NHDaly
approved these changes
May 16, 2024
NHDaly
reviewed
May 16, 2024
Merged
d-netto
added a commit
that referenced
this pull request
May 17, 2024
Update ProfileEndpoints version. Note that #35 introduced a breaking change in the sense we're no longer passing the profiling parameters for the `/debug_engine` endpoint in the query parameters, but are now passing them in the JSON body. Because of this I'm making this PR a major version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from passing the profiling parameters in the query parameters to passing them in the JSON body.
This makes it easier to forward requests to the /debug_engine endpoint from an intermediate service, which is now able to "blindly" forward the request to the /debug_engine endpoint without parsing and reconstructing the query parameters.