Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a branch in the debug super-endpoint to remove profiles #43

Closed
wants to merge 3 commits into from

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Jun 7, 2024

No description provided.

@d-netto d-netto requested a review from Drvi June 7, 2024 16:55
@d-netto d-netto force-pushed the dcn-profile-removal branch 3 times, most recently from 5d9f781 to 7251762 Compare June 7, 2024 17:03
src/ProfileEndpoints.jl Outdated Show resolved Hide resolved
@d-netto d-netto force-pushed the dcn-profile-removal branch from 7251762 to a001953 Compare June 7, 2024 17:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.81%. Comparing base (ffd6913) to head (96d2721).

Files Patch % Lines
src/ProfileEndpoints.jl 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   90.00%   81.81%   -8.19%     
==========================================
  Files           1        1              
  Lines         190      209      +19     
==========================================
  Hits          171      171              
- Misses         19       38      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/ProfileEndpoints.jl Outdated Show resolved Hide resolved
@d-netto d-netto force-pushed the dcn-profile-removal branch 3 times, most recently from bf7befe to 59f3da1 Compare June 7, 2024 18:15
@d-netto d-netto force-pushed the dcn-profile-removal branch from 59f3da1 to 96d2721 Compare June 7, 2024 18:19
test/runtests.jl Show resolved Hide resolved
src/ProfileEndpoints.jl Outdated Show resolved Hide resolved
src/ProfileEndpoints.jl Outdated Show resolved Hide resolved
@d-netto d-netto force-pushed the dcn-profile-removal branch from 5ab61a6 to f25e66e Compare June 9, 2024 23:44
@d-netto d-netto requested a review from NHDaly June 10, 2024 10:18
@d-netto
Copy link
Member Author

d-netto commented Jun 11, 2024

Closing it since we'll be pursuing another direction for handling profile deletion.

@d-netto d-netto closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants