add BenchmarkTools integration #1
Conversation
| @@ -0,0 +1,15 @@ | |||
| using BenchmarkTools | |||
There was a problem hiding this comment.
Been a while since I touched this code, but don't think you need this.
|
|
||
| @inline function posthook(id) | ||
| Valgrind.Callgrind.stop_instrumentation() | ||
| Valgrind.Callgrind.dump_stats_at(id) |
There was a problem hiding this comment.
I'm guessing you want dump_stats_at in the sample_result hook instead if you're trying to store the result of dump_stats_at as part of your benchmark results.
| @reexport using BenchmarkTools | ||
|
|
||
| @inline function prehook() | ||
| Valgrind.Callgrind.zero_stats() |
There was a problem hiding this comment.
You could move zero_stats into the setup_prehook just so it's more isolated from the code being benchmarked, i.e. its not part of the function at https://github.com/Zentrik/BenchmarkTools.jl/blob/a77bfca26390681d889460366cb9980ba36103c9/src/execution.jl#L656-L666
| prehook = prehook, | ||
| posthook = posthook, | ||
| enable_customizable_func = :ALL, | ||
| ) |
There was a problem hiding this comment.
If you don't want to run the normal benchmarking BenchmarkTools does you can set run_customizable_func_only to true.
No description provided.