Introduce CustomIDArray to access Arrays with contact IDs
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are Arrays which can be accessed through custom indices
|
Closed because of overkill |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just putting it out here, probably not the most elegant solution to fix #288, and I am not really sure whether we want to do it like this, so feel free to reject this PR. The idea of this PR is that arrays can be accessed with custom indices, e.g.
sim.weighting_potentials[100]to get theWeightingPotentialof the contact with ID100.There are still no checks if mutliple contacts in a config file have the same contact ID,
and by accessing elements with custom indices, I rely on
findfirstwhich might not be the most efficient way.