Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port UnitfulRecipes docs #302

Merged
merged 6 commits into from
Sep 27, 2022
Merged

port UnitfulRecipes docs #302

merged 6 commits into from
Sep 27, 2022

Conversation

t-bltg
Copy link
Member

@t-bltg t-bltg commented Sep 26, 2022

For JuliaPlots/Plots.jl#4371.

This will need some adjustments regarding binder and notebooks, but it's a start.

@t-bltg t-bltg marked this pull request as draft September 26, 2022 15:55
@t-bltg
Copy link
Member Author

t-bltg commented Sep 26, 2022

@gustaphe or @briochemc, do you know where the @__BINDER_ROOT_URL__ and @__NBVIEWER_ROOT_URL__ in https://github.com/jw3126/UnitfulRecipes.jl/blob/6e1d43e5cff1ab871dccd0e7848b63ab50e4ddde/docs/lit/examples/1_Examples.jl#L5 is defined ?

@t-bltg t-bltg marked this pull request as ready for review September 27, 2022 06:27
@t-bltg t-bltg merged commit 7981817 into JuliaPlots:master Sep 27, 2022
@t-bltg t-bltg deleted the unitf branch September 27, 2022 06:28
@briochemc
Copy link

briochemc commented Oct 23, 2022

@gustaphe or @briochemc, do you know where the @__BINDER_ROOT_URL__ and @__NBVIEWER_ROOT_URL__ in https://github.com/jw3126/UnitfulRecipes.jl/blob/6e1d43e5cff1ab871dccd0e7848b63ab50e4ddde/docs/lit/examples/1_Examples.jl#L5 is defined ?

It's from Literate.jl, (see, e.g., in its docs).

EDIT: Oops, sorry for the noise in reviving this old PR thread when it's already been merged... I got confused by emails and thought I had just been notified of this.

@t-bltg
Copy link
Member Author

t-bltg commented Oct 24, 2022

Thanks, still useful if someone wants to improve the unitfulrecipes documentation.

Currently, those are commented out: the binder and notebooks are unavailable in https://docs.juliaplots.org/stable/generated/unitfulrecipes_examples/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants