Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nodejs path list #19

Merged
merged 11 commits into from
Jan 30, 2025
Merged

Use nodejs path list #19

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a5e5159
Use nodejs path list
fonsp Aug 10, 2024
43921b1
move into function
fonsp Aug 10, 2024
a557373
oops
fonsp Aug 10, 2024
aba3512
Update setup_build.jl
fonsp Aug 10, 2024
56116dd
asdf
fonsp Aug 14, 2024
db363cb
Merge branch 'main' into nodejs-path-list
fonsp Jan 30, 2025
b38fd15
Merge branch 'main' into nodejs-path-list
fonsp Jan 30, 2025
9a4aaeb
Merge branch 'main' into nodejs-path-list
fonsp Jan 30, 2025
fb7e29e
Update setup_build.jl
fonsp Jan 30, 2025
6e9192a
Update setup_build.jl
fonsp Jan 30, 2025
967334b
dfsa
fonsp Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/setup_build.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ const npm = !Sys.iswindows() ? NodeJS_20_jll.npm : let
isfile(new) ? new : NodeJS_20_jll.npm
end

const npm_cmd = let
# Add NodeJS PATH to the existing PATH environment variable
path_sep = Sys.iswindows() ? ';' : ':'
path_list = prepend!(split(get(ENV, "PATH", ""), path_sep), NodeJS_20_jll.PATH_list)
path = join(path_list, path_sep)
addenv(`$(npm)`, "PATH" => path)
end

function get_build_dir()
build_node(@get_scratch!("build_dir3"))
end
Expand All @@ -29,8 +37,8 @@ function build_node(dir)
end

cd(dir) do
run(`$npm --version`)
run(`$npm install`)
run(`$npm_cmd --version`)
run(`$npm_cmd install`)
end

dir
Expand Down
Loading