Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to faq #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update link to faq #286

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 18, 2022

@dimpase Is the link https://cddlib.github.io/polyhedral_faq/#x1-250002.22 expected to change ? The tag #x1-250002.22 seems fragile

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #286 (c594607) into master (4e8b28c) will increase coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   88.35%   88.96%   +0.60%     
==========================================
  Files          37       37              
  Lines        2912     3036     +124     
==========================================
+ Hits         2573     2701     +128     
+ Misses        339      335       -4     
Impacted Files Coverage Δ
src/repop.jl 93.75% <ø> (+0.31%) ⬆️
src/lphrep.jl 90.29% <0.00%> (-0.14%) ⬇️
src/vecrep.jl 100.00% <0.00%> (ø)
src/triangulation.jl 100.00% <0.00%> (ø)
src/interval.jl 99.21% <0.00%> (+0.01%) ⬆️
src/iterators.jl 99.23% <0.00%> (+0.03%) ⬆️
src/liftedrep.jl 98.59% <0.00%> (+0.04%) ⬆️
src/show.jl 98.52% <0.00%> (+0.06%) ⬆️
src/default.jl 86.66% <0.00%> (+0.09%) ⬆️
src/projection.jl 91.07% <0.00%> (+0.16%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8b28c...c594607. Read the comment docs.

@dimpase
Copy link

dimpase commented Jan 18, 2022

I think one needs to create a proper LaTeX label, it would allow for a robust link.

@dimpase
Copy link

dimpase commented Jan 18, 2022

you are welcome to do a PR on cddlib/polyhedral_faq GH repo to create such a tag.

@dimpase
Copy link

dimpase commented Jan 18, 2022

OK, I think it's a bit more complicated. To achieve this (using LaTeX labels for html tags) one needs something like make4ht filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants