Add support for prop_callback
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation implied that `prop_callback` was supported, but in fact, that feature hadn't been implemented. This also fixes a bug with evaluating the gradient via the Taylor series, for immutable states.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
========================================
- Coverage 86.3% 84.1% -2.2%
========================================
Files 4 4
Lines 299 314 +15
========================================
+ Hits 258 264 +6
- Misses 41 50 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation implied that
prop_callbackwas supported, but in fact, that feature hadn't been implemented.This also fixes a bug with evaluating the gradient via the Taylor series, for immutable states.