-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#12 - Parsing models with Linear Affine Dynamics #13
Conversation
not urgent, but the tests need to be accomodated to the new convention for the input constraints context: since the type |
In the last push i changed the design of the inner loops of The drawback of this approach is that it is not optimal performance-wise, since it does the same operation, such as taking a gradient, more than once. |
src/convert.jl
Outdated
# check if the expression defines a hyperplane | ||
if is_linearcombination(lhs) && is_linearcombination(rhs) | ||
return true | ||
else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just return is_linearcombination(lhs) && is_linearcombination(rhs)
?
Ready from my side, i've checked that the issues above are fixed, and those which are not, left for later. This PR adds the new function |
Closes #12.
Closes #14.
Closes #17.
Closes #18.
Closes #22.