Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upate readme on yanking and version changes #106278

Closed
wants to merge 3 commits into from

Conversation

rafaqz
Copy link
Contributor

@rafaqz rafaqz commented May 6, 2024

This PR is a response to yanking being highly discouraged these days, but still suggested in the README.

I've attempted to start to outline the alternative but input would be appreciated.

@rafaqz
Copy link
Contributor Author

rafaqz commented May 6, 2024

See #102850 and #104235 for examples, the closed PR seems to be doing what the readme suggests, and the final solution is not mentioned in the readme.

@rafaqz rafaqz marked this pull request as draft May 6, 2024 17:17
README.md Outdated Show resolved Hide resolved
Co-authored-by: Felix Cremer <[email protected]>
@rafaqz
Copy link
Contributor Author

rafaqz commented May 6, 2024

Some comments from @StefanKarpinski on slack regarding the current permissable context for yanking:

  • If a version is actually dangerous to use, it should be yanked
  • Like it has a security vulnerability or someone accidentally committed an rm -rf / call
  • “Oops, I released a version with a bug” is not a reason

And in response to: "But the readmes for general registry and ColPrac still both say to yank if you register a version with too wide compat bounds"

  • No, that’s not right. You should just fix the compat bounds in the registry
  • And ideally, also make a release that has the right bounds in the project file
  • Largely just because it’s confusing when those don’t match

@felixcremer
Copy link

This should close item three of #104849.

Also see the discussion in #104800.

@rafaqz
Copy link
Contributor Author

rafaqz commented May 6, 2024

Ah so those guidelines are recently added. That is somewhat confusing as they are not really in line with discussions on slack.

@ericphanson
Copy link
Member

IMO if we are going to suggest manual changes to compat bounds, we need reviewers who are able and willing to review/merge. Maybe we have that? Not really sure, those PRs tend to linger for awhile I think

@LilithHafner
Copy link
Member

those PRs tend to linger for awhile I think

e.g. #85431

@rafaqz
Copy link
Contributor Author

rafaqz commented May 7, 2024

This was merged when it passed:
#104235

@rafaqz
Copy link
Contributor Author

rafaqz commented May 7, 2024

These seem to mostly get merged the same day?
https://github.com/JuliaRegistries/General/issues?q=label%3A%22compat+fix%22+

They also seem to be nearly 100% merged by @giordano . It would be good to hear your thoughts here Mosè, I'm mostly trying to update the guidlines to match your advice in PRs.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Jun 7, 2024
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants