-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copulas.jl - retroactive compat bound tightening on TaylorSeries.jl #115345
Conversation
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
I would like this to be manually merged. Explanation are in the top post. [noblock] |
I suggest pinging a maintainer specifically, possibly this is lost in the swamp of PRs. |
There's conflicts here holding back the merge. |
@BioTurboNick Do you have commit access to this repo? |
Conflicts solved. They appeard because I released another version while this PR was waiting, should be good to go now. [noblock] Errr scratch that, not working. |
Nope, just being helpful :-) |
@ViralBShah Okay this time should be good to go. [noblock] |
Hey,
Following guidance from @BioTurboNick on slack and while #104849 is still pending, I try in this PR to retroactively tighten the lower bound on
TaylorSeries.jl
on recent versions ofCopulas.jl
: at the time, I did use a feature that was only available inTaylorSeries > 0.15
but kept the old compat bound...These days, it results in issues such as lrnv/Copulas.jl#207 and lrnv/Copulas.jl#217. If these issues are usually solved by
]up
or even]up TaylorSeries
, it is still anoying.Warning: Although I have respected these docs of the compat file, I am not sure the fix I applied will be working correctly, and would appreciate some human taking the time to check it up before merging :)