Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: RDataGet v0.1.0 #67666

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: a115732e-4334-4ecb-8ea3-f683e7f66d4d
Repo: https://github.com/frankier/RDataGet.jl.git
Tree: 7f5ec40b2319f3790918744507025e13cbc31ce9

Registrator tree SHA: 8e1a5ac2695627143951512d700c7e3c445102ec
JuliaRegistrator referenced this pull request in JuliaPsychometricsBazaar/RDataGet.jl Sep 4, 2022
@JuliaRegistrator JuliaRegistrator temporarily deployed to stopwatch September 4, 2022 10:44 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

Your new package pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README and the AutoMerge guidelines. The following guidelines were not met:

  • Package name similar to 1 existing package.
    1. Similar to RDatasets. Damerau-Levenshtein distance 2 is at or below cutoff of 2.

Note that the guidelines are only required for the pull request to be merged automatically. However, it is strongly recommended to follow them, since otherwise the pull request needs to be manually reviewed and merged by a human.

After you have fixed the AutoMerge issues, simple retrigger Registrator, which will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless of course the AutoMerge issue is that you skipped a version number, in which case you should change the version number).

If you do not want to fix the AutoMerge issues, please post a comment explaining why you would like this pull request to be manually merged.

Since you are registering a new package, please make sure that you have also read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1


If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

@frankier
Copy link
Contributor

frankier commented Sep 4, 2022

[noblock]

The package name is deliberately a play on RDatasets. Although it has low Damerau-Levenshtein distance, the difference in capitalisation makes clear that this is a different approach that fetches datasets rather than vendoring them.

I certainly don't want to step on any toes regarding RDatasets, and this package is supposed to be complimentary. It seems within JuliaStats it is considered low-priority/feature-complete. See JuliaStats/RDatasets.jl#141 as well a quite a few issues from people who are wanting something else from the package. On the other hand this RDataGet.jl approach could be added to RDatasets, but that would require need RDatasets to have (possibly new) maintainers who want to evolve it.

@frankier
Copy link
Contributor

frankier commented Sep 7, 2022

[noblock]

I would like to go ahead with publishing this package. Perhaps eventually it can make its way into RDatasets.jl directly, but given there is low reviewer capacity in JuliaStats, having a specific package for this for the time being seems like it should probably be okay.

@giordano giordano merged commit 4cad0b7 into master Sep 12, 2022
@giordano giordano deleted the registrator/rdataget/a115732e/v0.1.0 branch September 12, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants