Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "LocalRegistry" to "0.4" #13

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link

This pull request changes the compat entry for the LocalRegistry package from 0.3 to 0.3, 0.4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@DilumAluthge DilumAluthge force-pushed the compathelper/new_version/2021-05-18-00-38-11-206-2673131826 branch from 99e8384 to 5b15e26 Compare May 18, 2021 00:38
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #13 (5b15e26) into master (46f17fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #13   +/-   ##
======================================
  Coverage    9.40%   9.40%           
======================================
  Files          14      14           
  Lines         202     202           
======================================
  Hits           19      19           
  Misses        183     183           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46f17fd...5b15e26. Read the comment docs.

@GunnarFarneback
Copy link

The call to LocalRegistry.register needs to be updated to be compatible with LocalRegistry 0.4 and compatibility with 0.3 needs to be dropped. (Second positional argument should be changed to keyword argument registry.)

@DilumAluthge DilumAluthge marked this pull request as draft May 19, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant