Call user function only once in mean
#151
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override the standard
mapreduce
machinery to promote accumulator type.This avoid calling the function twice, which can be confusing.
Fixes #49 but with a more general solution than #80.
Cc: @stevengj @kagalenko-m-b
Unfortunately, performance drops for a
Float64
vector:This is simply due to
sum
being slower wheninit
is provided as it callsmapfoldl
under the hood in that case: