Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when negative weights or zero sum are used when sampling #834

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Sep 3, 2022

  1. Error when negative weights or zero sum are used when sampling

    These can give misleading results. Checking the sum is cheap, but
    checking for negative weights is relatively costly. Therefore, compute
    this information the first time it is requested, and store it in
    the weights vector like the sum.
    
    `efraimidis_ares_wsample_norep!` and `efraimidis_aexpj_wsample_norep!` already
    checked these, but throwing different exception types. Harmonize exceptions
    across algorithms as they can all be called by `sample`.
    nalimilan committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    57fb55f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81560a3 View commit details
    Browse the repository at this point in the history
  3. Another fix

    nalimilan committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    3c1e60d View commit details
    Browse the repository at this point in the history
  4. And another one

    nalimilan committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    c8a2129 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Fixes

    nalimilan committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    1877595 View commit details
    Browse the repository at this point in the history