Add intersect method #496
Add intersect method #496
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.30 #496 +/- ##
========================================
Coverage ? 85.87%
========================================
Files ? 17
Lines ? 899
Branches ? 0
========================================
Hits ? 772
Misses ? 127
Partials ? 0 Continue to review full report at Codecov.
|
| new_o = max(tg_inf1.o, tg_inf2.o) | ||
| return TimeGrid(new_o, tg_inf1.p) | ||
| end | ||
| function intersect(tg_fin1::TimeGrid{T,P,:finite}, tg_fin2::TimeGrid{T,P,:finite}) where {T,P} |
There was a problem hiding this comment.
I found a case that might yield empty TimeGrid:
julia> tg = TimeGrid(DateTime(2021, 1, 1, 0), Hour(1), 24)
24-element TimeGrid{DateTime, Hour, :finite}:
2021-01-01T00:00:00
⋮
2021-01-01T23:00:00
/ 1 hour
julia> tg′ = TimeGrid(DateTime(2021, 1, 1, 0, 30), Hour(1), 24)
24-element TimeGrid{DateTime, Hour, :finite}:
2021-01-01T00:30:00
⋮
2021-01-01T23:30:00
/ 1 hour
julia> intersect(collect(tg), collect(tg′))
DateTime[]
There was a problem hiding this comment.
In fact I was wrong on slack there is a way to infinite with infinite intersection being empty
There was a problem hiding this comment.
I rewrote some parts and added more tests.
The current behavior of intersecting tg with different periods is method error. What do you think about that?
There was a problem hiding this comment.
The current behavior of intersecting tg with different periods is method error. What do you think about that?
That might need IrregularTimeGrid implemented.
I think we can revisit it later, putting a TODO here is fine for me.
I still don't make a perfect algo come out. Here is my two cents:
- For the case
tg.p <: Period(or maybe narrow down toFixedPeriod?), treat all the period asIntand we can get aTimeGrid. - For the case
tg.p <: Float64(andIrrationalincluded. Although I knowπis marked aIrrationaltype, all calculation on it are approximations.), just fallback to theintersect(::Vector, ::Vector)calculation and outputIrregularTimeGrid.
Co-authored-by: Iblis Lin <[email protected]>
Co-authored-by: Iblis Lin <[email protected]>
Co-authored-by: Iblis Lin <[email protected]>
No description provided.