Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piracy: Add kwarg treat_as_own #140

Merged
merged 6 commits into from
Jun 24, 2023
Merged

Piracy: Add kwarg treat_as_own #140

merged 6 commits into from
Jun 24, 2023

Commits on Jun 24, 2023

  1. Add piracy kwarg treat_as_own

    @lgoettgens
    lgoettgens committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    3edcdee View commit details
    Browse the repository at this point in the history

  2. Add tests for piracy kwarg treat_as_own

    @lgoettgens
    lgoettgens committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    f1f32e7 View commit details
    Browse the repository at this point in the history

  3. Make julia pre-1.5 happy

    @lgoettgens
    lgoettgens committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    4e2756d View commit details
    Browse the repository at this point in the history

  4. Add second treat_as_own kwarg to piracy tests

    @lgoettgens
    lgoettgens committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    f5d3ad4 View commit details
    Browse the repository at this point in the history

  5. Address comments 

    * Merge both kwargs into one
* Remove type constraint to allow arbitrary containers
* Remove default value for non user facing functions
    @lgoettgens
    lgoettgens committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    9e0a05b View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into lg/piracy

    @fingolfin
    fingolfin authored Jun 24, 2023
    Configuration menu
    Copy the full SHA
    1114993 View commit details
    Browse the repository at this point in the history