Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dryrun: keep track of loop variables from parent testsets #28

Merged
merged 1 commit into from
Aug 6, 2021
Merged

dryrun: keep track of loop variables from parent testsets #28

merged 1 commit into from
Aug 6, 2021

Commits on Aug 1, 2021

  1. dryrun: keep track of loop variables from parent testsets 

    Partially fixes #27.

The full fix might be to make `resolve!` also keep track of these
loop variables; but this would involve storing lists of collected
iterators for each nested testset: once we evaluate an iterator
for filtering in `resolve!`, we have to store it in case
it has some random behavior (e.g. `rand(1:9, i)` where `i` is
a loop variable from a parent testset), in which case re-evaling
it at execution time would lead to inconsistency.
The testset tree would also have to be traversed depth-first by also
unfolding testset-for. This could be a nice improvement if the perfs
don't suffer (instead of storing parent strings subjects and looping
through them, we would store iterators and recurse into them).
    @rfourquet
    rfourquet committed Aug 1, 2021
    Configuration menu
    Copy the full SHA
    c3b9527 View commit details
    Browse the repository at this point in the history