Minor fixup to Gentle Close PR: Wait until the worker closes itself, before force-closing it in response to the closed pipes. #155
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
reviewed
Apr 20, 2024
| if w.gracefully_closed | ||
| @static if !Sys.isapple() | ||
| # NOTE: THIS CAUSES A HANG ON MACOS! We can remove this if-check once | ||
| # the julia issue is resolved: |
quinnj
approved these changes
Apr 20, 2024
|
Hmmm, macos 1.9/1.10 failures are both on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #151.
When we request a worker to gracefully close, the worker closes its pipes and then shutsdown.
Without this small commit, the coordinator would detect the closed pipes, and call terminate! in response.
This change tells the coordinator: "Hey, don't worry, we asked it to shut down! Just chill out, and wait for it to go to sleep peacefully, my friend."
BUT due to JuliaLang/julia#54145, we have to introduce a less-reliable
sleep(5)on macos. :/That should be long enough to cover it though, and even if this is too slow, all that will happen is the worker will die with SIG15 instead of exiting 0.