Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localized #145

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Localized #145

wants to merge 2 commits into from

Conversation

rofinn
Copy link
Member

@rofinn rofinn commented Aug 12, 2018 •
edited
Loading

Closes #121

  • Replaced ZonedDateTime w/ Localized{<:AbstractDateTime}
  • We didn't need Localized/ZonedDateTime inner constructors, so turned them to outer constructors.
  • Renamed all variable references of zdt with ldt
  • Renamed '2' conversion methods to use localized rather than zdt

@rofinn rofinn mentioned this pull request Aug 12, 2018
Open
4 tasks
@omus
Copy link
Member

omus commented Aug 14, 2018

Thanks for the PR. I think we should sit on this for a little while as I'd like to experiment with Localized{Date} and Localized{Time} to avoid too much churn. Having a parameterized Localized type will allow us to support higher-accuracy instant types which will be much more compossible with other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rofinn @omus