Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FixedTimeZone isbits #354

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Make FixedTimeZone isbits #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d53218d
Switch FixedTimeZone to InlineStrings name
Wynand Aug 6, 2021
76b1fdd
Merge branch 'master' into wy/isbits-fixedtimezone
omus Oct 12, 2021
bf015db
Revert version bump
omus Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ version = "1.6.0"
[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
InlineStrings = "842dd82b-1e85-43dc-bf29-5d0ee9dffc48"
LazyArtifacts = "4af54fe1-eca0-43a8-85a7-787d91b784e3"
Mocking = "78c3b35d-d492-501b-9361-3d52fe80e533"
Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
Expand All @@ -16,6 +17,7 @@ Unicode = "4ec0a83e-493e-50e2-b9ac-8f72acf5a8f5"

[compat]
Downloads = "1"
InlineStrings = "1.0"
LazyArtifacts = "1.3"
Mocking = "0.7"
RecipesBase = "0.7, 0.8, 1"
Expand Down
1 change: 1 addition & 0 deletions src/TimeZones.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ using Printf
using Serialization
using RecipesBase: RecipesBase, @recipe
using Unicode
using InlineStrings: InlineString15

import Dates: TimeZone, UTC

Expand Down
3 changes: 2 additions & 1 deletion src/types/fixedtimezone.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const FIXED_TIME_ZONE_REGEX = r"""
A `TimeZone` with a constant offset for all of time.
"""
struct FixedTimeZone <: TimeZone
name::String
name::InlineString15
offset::UTCOffset
end

Expand Down Expand Up @@ -95,3 +95,4 @@ end

name(tz::FixedTimeZone) = tz.name
rename(tz::FixedTimeZone, name::AbstractString) = FixedTimeZone(name, tz.offset)

2 changes: 2 additions & 0 deletions test/types/fixedtimezone.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@testset "FixedTimeZone" begin
@test isbitstype(FixedTimeZone)

@test FixedTimeZone("0123") == FixedTimeZone("UTC+01:23", 4980)
@test FixedTimeZone("+0123") == FixedTimeZone("UTC+01:23", 4980)
@test FixedTimeZone("-0123") == FixedTimeZone("UTC-01:23", -4980)
Expand Down