Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative path to .vtu in .pvtu files #152

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

bmxam
Copy link
Contributor

@bmxam bmxam commented Oct 3, 2024

This PR intends to replace absolute paths in .pvtu files by relative paths, as described in #151.

I wrote the truth table of the if block in pvtk_grid._pvtk_vtk_filename_prefix and it seems to me that what we want is simply if !relative_to_pvtk (...) else (...). At least the tests I've ran are ok.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.90%. Comparing base (74e55ff) to head (572b128).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          15       15           
  Lines         873      873           
=======================================
  Hits          846      846           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jipolanco
Copy link
Member

Thank you!

@jipolanco jipolanco merged commit 618b1ea into JuliaVTK:master Oct 4, 2024
7 checks passed
jipolanco referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants