Infoview autoclose #103
Infoview autoclose #103
Conversation
Codecov Report
@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 92.15% 85.71% -6.45%
==========================================
Files 25 17 -8
Lines 1109 686 -423
==========================================
- Hits 1022 588 -434
- Misses 87 98 +11
Continue to review full report at Codecov.
|
| function lean.is_lean_buffer() | ||
| local filetype = vim.opt.filetype:get() | ||
| function lean.is_lean_buffer(buffer) | ||
| local filetype = vim.api.nvim_buf_get_option(buffer or 0, "ft") |
There was a problem hiding this comment.
I'm a big fan of the OOP options but unfortunately I couldn't find a way to specify a particular buffer when using them.
|
Also while working on this I've already started to see intermittent MacOS failures (e.g. this one), so we may want to ask a maintainer about nvim-lua/plenary.nvim#186 soon! |
rish987
force-pushed
the
infoview/autoclose
branch
from
0db73cd
to
00eba9c
Compare
rish987
force-pushed
the
infoview/autoclose
branch
from
1c81e34
to
3bc514b
Compare
skip-checks: true
|
Honestly I don't see much purpose in having two concepts personally. We have vim concepts already of windows and buffers. An infoview is a lean concept, if it has some contents, that can be a buffer to me. |
|
Will create an issue for this, but how this is useful will become more clear once we've implemented #84. The idea is to be able to swap between infos with different pins (using a telescope picker) and let multiple infoviews share the same info. Figured we might as well decouple immediately (#105) because it makes the code easier to understand. |
|
It's likely easier to start from scratch here given the conflicts, so closing this one. |
Working on this made me realize that we'll probably want to eventually decouple the concept of an infoview (which is just contains the pure tactic/term state data) from the "infoview view" window (the thing that can be opened/closed). Will work on this once we actually have some kind of persistent state feature with the infoview (e.g. #84).
Closes #43.