Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lithuanian QWERTY layout #824

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Lithuanian QWERTY layout #824

merged 6 commits into from
Jan 2, 2025

Conversation

tenextractor
Copy link
Contributor

Based on Samsung keyboard
image

<key key0="š"/>
<key key0="ų"/>
<key key0="ū"/>
<key key0="ž"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not having such rows is one of the purpose of this keyboard. All these letters should be swipes on other keys.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a copy of the traditional Lithuanian layout, used on PC, Samsung, AnySoftKeyboard, and some other keyboards.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this app, symbols in the corner of keys are more easily accessed than on other layouts. It's not useful to copy layouts directly from other apps, instead they should be adapted to make use of the app's features.

@Julow Julow mentioned this pull request Dec 19, 2024
@Julow Julow added this to the 1.31.0 milestone Dec 21, 2024
@tenextractor
Copy link
Contributor Author

The most common letters now have separate keys, the rest are swipes
image

<key key0="b" key2="\?" key3="/"/>
<key key0="n" key2=":" key3=";"/>
<key key0="m" key2="&quot;" key3="'"/>
<key key0="ų"/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ų a frequently used letter ? It could be moved as a swipe to make the shift and delete keys bigger, which is a good thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's have separate keys for Ė and Ų.

@Julow
Copy link
Owner

Julow commented Dec 29, 2024

What would be the extra_keys for Lithuanian ? See my comments in this review: #828 (review)

@tenextractor
Copy link
Contributor Author

The extra_keys would be ą|č|ȩ|ė|į|š|ų|ū|ž

Copy link
Owner

@Julow Julow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's merge!

There were already extra keys for Lithuanian: accent_ogonek:ą:ę:į:ų@s|accent_caron:č:š:ž@f|accent_dot_above:ė@s|accent_macron:ū@o|€
This means that accent_ogonek should be added on the s key if ąęįų are not already on the layout, same for the other keys. Similarly for the others. This is useful information for the future as I plan to have options to control how dead-keys and extra keys work.

@Julow Julow merged commit 115eda4 into Julow:master Jan 2, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants