Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tia chen nathan j edwards add new file popup #128

Merged
merged 30 commits into from
Mar 15, 2024

Conversation

nathan-j-edwards
Copy link
Collaborator

@nathan-j-edwards nathan-j-edwards commented Mar 15, 2024

Description

We completed the following tasks:

  • Added date field to Add File Popup
    • User can now select date from calandar dropdown
    • Dates are passed in as file names
    • Previously used dates are disabled for user
  • Updated tag field in Add File Popup
    • Tags respond appropriately to user interaction and submit with form
    • Submission is disabled until one tag is selected and selection is disabled after three tags are selected
  • Updated styling for Add File Popup
    • With the exception of the calandar icon, all styling complies with Figma
    • Background is blured and disabled when popup is active
  • Integrated Add File Popup with the rest of Senior Files page

Issues

Work in progress for #86.

Screenshots

User can open popup by clicking Add File button. Date can be selected by clicking the input box and selcting date from calandar dropdown. Tag selection responds to hover, and tags can be selected like checkboxes. Popup can be submitted by clicking create and can only be exited by clicking cancel.

Screenshot (32)
Screenshot (33)

Test

Files can be created using popup. Once created, files will appear in the file section of MongoDB, and date will be disabled for caladar. Senior File page is currently populated by mock files.

Possible Downsides

The user can currently edit the date directly. If they enter something that is not a properly formated date, the calandar will either revert to the first of the current month or the first of January 2000.
Clicking on the calander icon does not cause the calandar dropdown to activate. We do not currently have a way to fix this without negativly impacting the functionality of the datepicker component.

Additional Documentations

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
the-legacy-project2 ❌ Failed (Inspect) Mar 15, 2024 1:30am

Copy link
Collaborator

@nickbar01234 nickbar01234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job team! You guys nailed the functional requirements and this was a hard ticket! I will go ahead and merge this PR in for our client demo tomorrow. There's some comments / styling nits we need to address, but we can revisit them after spring break!

src/components/user/AddFile.tsx Show resolved Hide resolved
src/components/user/AddFile.tsx Show resolved Hide resolved
src/components/user/AddFile.tsx Show resolved Hide resolved
@nickbar01234 nickbar01234 merged commit 6ef0049 into main Mar 15, 2024
4 checks passed
@nickbar01234 nickbar01234 deleted the Tia-Chen-nathan-j-edwards-add-new-file-popup branch March 15, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants