Add popup to edit user #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nickbar01234
commented
Mar 25, 2024
| const chapter = await prisma.chapter.findFirstOrThrow({ | ||
| where: { | ||
| id: user.ChapterID ?? "", | ||
| students: { |
There was a problem hiding this comment.
We can get all the necessary information with 1 call to the database!
nickbar01234
commented
Mar 25, 2024
| @@ -34,7 +34,7 @@ const InfoTile = (params: InfoTileProps) => { | |||
|
|
|||
| return ( | |||
| <div className="flex h-fit w-full flex-col gap-y-4 rounded-lg bg-white p-6 shadow-lg"> | |||
| <div className="flex justify-between"> | |||
| <div className="relative flex justify-between"> | |||
There was a problem hiding this comment.
We need this for the popup with the ... icon. Otherwise, it will fly out of the screen.
cledi01
approved these changes
Mar 25, 2024
Closed
johnny-t06
pushed a commit
that referenced
this pull request
Mar 27, 2024
johnny-t06
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement API route to edit user's position and display popup on chapter leader view to edit position.
Screenshots
Possible Downsides
I reused
Dropdownto implement edit position. To iterate quickly, I also changed the styling for assigning students to a senior. The resulting changes is different from what we have on the mockup. I can revisit the code later to adjust the background color to match the design if necessary.