-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add popup to edit user #132
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
const chapter = await prisma.chapter.findFirstOrThrow({ | ||
where: { | ||
id: user.ChapterID ?? "", | ||
students: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can get all the necessary information with 1 call to the database!
@@ -34,7 +34,7 @@ const InfoTile = (params: InfoTileProps) => { | |||
|
|||
return ( | |||
<div className="flex h-fit w-full flex-col gap-y-4 rounded-lg bg-white p-6 shadow-lg"> | |||
<div className="flex justify-between"> | |||
<div className="relative flex justify-between"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this for the popup with the ...
icon. Otherwise, it will fly out of the screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionality on my end as well. Everything looks good!
Description
Implement API route to edit user's position and display popup on chapter leader view to edit position.
Screenshots
Possible Downsides
I reused
Dropdown
to implement edit position. To iterate quickly, I also changed the styling for assigning students to a senior. The resulting changes is different from what we have on the mockup. I can revisit the code later to adjust the background color to match the design if necessary.