Update UI #135
Merged
Update UI #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbar01234
commented
Apr 2, 2024
There was a problem hiding this comment.
Using a parallel route results in a backend error if the user is not part of any chapter. I.e, their chapter ID will be undefined.
wkim10
reviewed
Apr 3, 2024
| (user) => user.role === "CHAPTER_LEADER" | ||
| ); | ||
|
|
||
| // const options: Parameters<typeof TileEdit>[0]["options"] = []; |
There was a problem hiding this comment.
nit: remove commented-out code if not needed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the user's tile to join chapters to match the new Figma styling.
Screenshots
By default, new users can join any chapters in the Legacy Project.
Having 1 pending chapter request will block the user from joining any other chapters.
Additional Documentations
I also fixed a bug with parallel routing. See comments for more information.