Tyler/caleb/drive #136
Merged
Tyler/caleb/drive #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew senior folder in correct chapter, and update share permissions on new member.
nickbar01234
reviewed
Apr 3, 2024
| @@ -67,6 +70,52 @@ export const POST = async (request: NextRequest) => { | |||
| approved: "APPROVED", | |||
| }, | |||
| }); | |||
|
|
|||
| const baseFolder = process.env.GOOGLE_BASEFOLDER; // TODO: make env variable | |||
There was a problem hiding this comment.
We can add GOOGLE_BASEFOLDER to src/env/schema.mjs to quickly detect missing variables. You can use the environment variables by importing from src/env/server.mjs (see next.config.mjs for examples)
nickbar01234
reviewed
Apr 3, 2024
| fields: "id", | ||
| }; | ||
|
|
||
| const { access_token, refresh_token } = (await prisma.account.findFirst( |
There was a problem hiding this comment.
nit: Use createDriveService from server/service
nickbar01234
reviewed
Apr 3, 2024
| ).files.create(fileCreateData); | ||
| const googleFolderId = (file as any).data.id; | ||
|
|
||
| await prisma.chapter.update({ |
There was a problem hiding this comment.
I wonder if it's necessary to include the new chapter ID as part of the folder name. We currently don't have any constraints that uni name is unique. What do you guys think?
nickbar01234
reviewed
Apr 3, 2024
| name: [ | ||
| `${seniorBody.firstname}_${seniorBody.lastname}-${randomUUID()}`, | ||
| ], | ||
| name: [`${seniorBody.firstname}_${seniorBody.lastname}_${senior.id}`], | ||
| mimeType: "application/vnd.google-apps.folder", | ||
| parents: [baseFolder], | ||
| }; |
There was a problem hiding this comment.
If we're changing the other route to use createDriveService, we should also make the changes here!
nickbar01234
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created new base folder, created folders for each chapter after new chapter created, create new folder in correct chapter for new senior, and updated folder sharing when new member added to chapter.
TODO: new file sharing
Issues
Resolve #58
Screenshots
Test
Create new chapters, seniors, and add members to chapters.
Possible Downsides
Additional Documentations