Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Boundary #177

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Error Boundary #177

merged 3 commits into from
Apr 29, 2024

Conversation

nickbar01234
Copy link
Collaborator

Description

  • Add UI to handle error and redirect
  • Update hamburger menu to be sticky

Screenshots

image image

Test

To test the behavior for error handling, enter a bogus id on dynamic routes. For example, /private/admin/home/chapters/[id-do-not-exist].

Additional Documentations

For admin, I only catch the error at /private/admin/home/chapters since nested segments can fail for many reasons, and I don't think it's our top priority to handle all the cases.

Copy link

vercel bot commented Apr 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
the-legacy-project2 ✅ Ready (Inspect) Visit Preview Apr 28, 2024 4:41am

Copy link
Collaborator

@johnny-t06 johnny-t06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nickbar01234 nickbar01234 merged commit 31eba0b into main Apr 29, 2024
4 checks passed
@nickbar01234 nickbar01234 deleted the nickbar01234/error-boundary branch April 29, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants