tyler/won added CardGrid support for 2 and 3 column grids #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tylerrlin
changed the title
nickbar01234
requested changes
Feb 19, 2024
wkim10
force-pushed
the
tyler/won/card-grid
branch
from
814487f
to
5cebe35
Compare
tylerrlin
force-pushed
the
tyler/won/card-grid
branch
from
f95b079
to
5c82e67
Compare
change senior name to first name and last name Co-authored-by: Tyler <[email protected]> finish first draft Co-authored-by: Tyler <[email protected]> reverted senior firstname/lastname field
nickbar01234
force-pushed
the
tyler/won/card-grid
branch
from
5c82e67
to
90e1985
Compare
nickbar01234
reviewed
Mar 7, 2024
nickbar01234
reviewed
Mar 7, 2024
nickbar01234
reviewed
Mar 7, 2024
nickbar01234
reviewed
Mar 7, 2024
nickbar01234
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thank you for your work! That was a handful of pages to implement. I went ahead and fixed some quick issues:
- Remove
@joinChapterrouting. We will eventually enforce that a user can only access views corresponding to their role. Therefore, anyone viewingchapter-leader/segment must have a chapter and been promoted. - Update
chapter-leader/memberstochapter-leader/usersfollowing the conventions we have in admin view.
I've left a couple of tiny changes to address. Once that's fixed, feel free to merge in whenever!
- Utilize
SearchableContainer.tsxinstead of manually plugging inSearchBar.tsx. - Update the logic to fetch pending users.
Co-authored-by: Tyler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added column support for CardGrid and updated pages that use column count.
Issues
Resolve #89
Screenshots
Test
Change column_count in CardGrid