-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tyler/won added CardGrid support for 2 and 3 column grids #90
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you guys! I think we should take it a step further and allow for the grid to collapse on smaller screen. For example, on a lg
screen, we probably only want to render 1 tile per row?
814487f
to
5cebe35
Compare
f95b079
to
5c82e67
Compare
change senior name to first name and last name Co-authored-by: Tyler <[email protected]> finish first draft Co-authored-by: Tyler <[email protected]> reverted senior firstname/lastname field
5c82e67
to
90e1985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work! That was a handful of pages to implement. I went ahead and fixed some quick issues:
- Remove
@joinChapter
routing. We will eventually enforce that a user can only access views corresponding to their role. Therefore, anyone viewingchapter-leader/
segment must have a chapter and been promoted. - Update
chapter-leader/members
tochapter-leader/users
following the conventions we have in admin view.
I've left a couple of tiny changes to address. Once that's fixed, feel free to merge in whenever!
- Utilize
SearchableContainer.tsx
instead of manually plugging inSearchBar.tsx
. - Update the logic to fetch pending users.
Co-authored-by: Tyler <[email protected]>
Description
Added column support for CardGrid and updated pages that use column count.
Issues
Resolve #89
Screenshots
Test
Change column_count in CardGrid