Validation Time and other edge cases for AddShift Modal #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer: Pam
Dates: April 8th
Time spent: 2 hours
Summary: Validation of AddShift times and form completion edge cases with visual Alert!
Testing Desktop:
Reflection: Had some trouble, stepped away and worked with Naomi on a similar ticket dealing with time, a lot of things clicked and it made this a lot better, I scrapped my previous progress and made an even cleaner implementation this way. I also am happy to have tackled other validation issues like when a form is incomplete and preventing the client from clicking submit anyways.
I did some serious stress testing and then maybe like 2/10 times it wouldn't allow the user to submit despite having valid information and I couldn't figure out why but it was a rare occurrence, just wanted to put that out there.
useEffect > useState is glorious, It fixed a huge BUG I was facing and I'm thankful for chatGPT for recommending it LOL.