Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend 42 Finished Categories Spreadsheet #52

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

alexanderviolet
Copy link
Collaborator

Title: Frontend 42 Finished Categories Spreadsheet

Names: Zoya and Alex

Date: December 8, 2024

How long did this ticket take you? 3ish hours

Description: category table that shows up when you select a category

Testing (before and after screenshots): compared with localhost

Takeaways: bools and borders were hard but we pulled through

Copy link
Collaborator

@jiyoonchoi jiyoonchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderviolet @zoyaamrit Nice work guys! I just have some requested changes here:
1. Alignment of buttons
Below is a screenshot of what I see while in your branch. I notice a gap in between the buttons and the buttons also seem to look a bit higher up than the dropdown.

Can we move the dropdown and buttons around so it fits the design?

Local:
Screenshot 2024-12-09 at 6 50 21 PM

2. Missing edit/delete buttons for category
I noticed there aren't edit/delete icons next to category, which is in the Figma design (the black pencil and red trash can)!
Screenshot 2024-12-09 at 6 47 08 PM

3. Missing border lines of the cells
I think we decided to include both vertical and horizontal lines for the table, right?

Extra note: I will update the text style stuff later, so you can ignore the mismatched font! (Since the spreadsheet modal is supposed to be a different font.)

Copy link
Collaborator Author

@alexanderviolet alexanderviolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-10 at 8 37 13 PM

Here's the columns and new symbols :D

@jiyoonchoi jiyoonchoi merged commit 5891fd9 into dev Jan 15, 2025
1 check failed
@jiyoonchoi jiyoonchoi deleted the frontend/42-Internal-View-Categories-Page branch January 15, 2025 17:59
@jiyoonchoi jiyoonchoi restored the frontend/42-Internal-View-Categories-Page branch January 15, 2025 18:00
@jiyoonchoi jiyoonchoi deleted the frontend/42-Internal-View-Categories-Page branch January 15, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants