Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buffermgrd] Use unix socket for redis connection #21

Closed
wants to merge 1 commit into from

Conversation

Junchao-Mellanox
Copy link
Owner

@Junchao-Mellanox Junchao-Mellanox commented Jun 4, 2024

Why I did this?

Most of the DB connection in buffermgrd is using unix socket. There is only one DB connection which is using TCP socket. It brings a few drawback:

  1. TCP socket is less efficiency
  2. TCP socket may fail if loopback interface is down. It could cause following error:
Apr 29 16:53:25.586513 sonic ERR swss#buffermgrd: :- main: Runtime error: Unable to connect to redis: Cannot assign requested address

How I did this

Change TCP socket to unix socket

How I verify this

Manual test

@Junchao-Mellanox Junchao-Mellanox changed the title Use unix socket for redis connection [buffermgrd] Use unix socket for redis connection Jun 5, 2024
@Junchao-Mellanox
Copy link
Owner Author

ci passed 4146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants