Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable using only the SSH agent if asked. #1284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gaima8
Copy link

@gaima8 gaima8 commented Nov 23, 2023

@gaima8
Copy link
Author

gaima8 commented Nov 25, 2023

Probably superseded by #1285

@chidanandpujar
Copy link
Collaborator

Hi @gaima8
Thanks ,
Please add unit tests and share the test results .
https://github.com/Juniper/py-junos-eznc/tree/master/tests/unit

Thanks .

@gaima8
Copy link
Author

gaima8 commented Nov 29, 2023

I've never written a python test before and not sure what the tests actually do, but I have added something.
The output from the nosedive command (as copied from https://github.com/Juniper/py-junos-eznc/blob/master/.github/workflows/pylint.yml) has the following obvious change between master and this branch.

-jnpr/junos/device.py                                    514     30    94%   49, 103-115, 196-197, 311-314, 378, 432-437, 498, 570, 853, 1037, 1044, 1121, 1133, 1486-1488
+jnpr/junos/device.py                                    519     33    94%   49, 103-115, 196-197, 311-314, 378, 432-437, 498, 570, 853, 1037, 1044, 1121, 1133, 1475-1477, 1499-1501

I don't know what any of the number relate to. jnpr/junos/device.py has lines 1475-1477, for example, but those lines are not remotely related to this change.

@chidanandpujar
Copy link
Collaborator

I've never written a python test before and not sure what the tests actually do, but I have added something. The output from the nosedive command (as copied from https://github.com/Juniper/py-junos-eznc/blob/master/.github/workflows/pylint.yml) has the following obvious change between master and this branch.

-jnpr/junos/device.py                                    514     30    94%   49, 103-115, 196-197, 311-314, 378, 432-437, 498, 570, 853, 1037, 1044, 1121, 1133, 1486-1488
+jnpr/junos/device.py                                    519     33    94%   49, 103-115, 196-197, 311-314, 378, 432-437, 498, 570, 853, 1037, 1044, 1121, 1133, 1475-1477, 1499-1501

I don't know what any of the number relate to. jnpr/junos/device.py has lines 1475-1477, for example, but those lines are not remotely related to this change.

Hi @gaima8
Thanks for adding the Unit tests .
I will run Unit and Functional tests and update the results .

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants