Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #1322 to pass no_validate #1323

Closed
wants to merge 3 commits into from
Closed

Fix for issue #1322 to pass no_validate #1323

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b07454
Fix for issue #1322 to pass no_validate
chidanandpujar Sep 6, 2024
8311892
Fix for issue #1322 to pass no_validate
chidanandpujar Oct 9, 2024
6286c94
Fix for issue #1322 to pass no_validate
chidanandpujar Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/jnpr/junos/utils/sw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,11 +984,17 @@ def _progress(report):
kwargs.update({"no_validate": True})

if issu is True:
if validate is False:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you explicitly setting the validate option as True always?

Are there any reference document , validation always be "True" in case of ISSU and NSSU

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we set the option validate=False, we are not passing on this option to request system software add/request system software nonstop-upgrade/request system software add.

no-validate
(Optional) When loading a software package or bundle with a different release, suppress the default behavior of the validate option.

validate
(Optional) Validate the software package or bundle against the current configuration as a prerequisite to adding the software package or bundle. This is the default behavior when the software package or bundle being added is a different release.

no-validate
(Optional) Starting in Junos OS Release 20.4R2, skip the validation step of the unified ISSU process.

# Need to pass the no_validate option via kwargs
kwargs.update({"no_validate": True})
_progress("ISSU: installing software ... please be patient ...")
return self.pkgaddISSU(
remote_package, vmhost=vmhost, dev_timeout=timeout, **kwargs
)
elif nssu is True:
if validate is False:
# Need to pass the no_validate option via kwargs
kwargs.update({"no_validate": True})
_progress("NSSU: installing software ... please be patient ...")
return self.pkgaddNSSU(remote_package, dev_timeout=timeout, **kwargs)
elif member_id is not None:
Expand Down
Loading