Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust writing rate to the baud rate #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mpergament
Copy link

The consoles have a 32 byte buffer, this gets overwritten when you go
more than 9600b/s.

The consoles have a 32 byte buffer, this gets overwritten when you go
more than 9600b/s.
@stacywsmith
Copy link

I think this is a good idea, but I would suggest a few minor enhancements to the implementation.

  1. If the user specifies a command-line baudrate option, that value isn't currently being passed to the Telnet object during initialization.

  2. Check to see if the user explicitly set the baudrate to 0. In that case, avoid divide by zero exception and do not sleep between writes.

  3. Make corresponding changes to the SecureShell object's write() and rawwrite() methods.

@mpergament
Copy link
Author

1 and 2 done. I am not sure I understand what you want in 3 though.

@vnitinv
Copy link
Contributor

vnitinv commented Dec 20, 2016

Thanks @mpergament. Your code was used in while merging netconify in PyEZ.
For telnet and console connection please use PyEZ from now onwards. refer
https://github.com/Juniper/py-junos-eznc/releases/tag/2.0.0

Thanks for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants