Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Add Azure VM disablePasswordAuth #506

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mcpeach9
Copy link

No description provided.

@mcpeach9 mcpeach9 requested a review from a team as a code owner May 20, 2022 21:33
chjlarson
chjlarson previously approved these changes May 20, 2022
Copy link

@chjlarson chjlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grammar in the Title is a little weird but otherwise syntax is good! Good Job!

jupiterone/questions/questions.yaml Outdated Show resolved Hide resolved
jupiterone/questions/questions.yaml Show resolved Hide resolved
jupiterone/questions/questions.yaml Outdated Show resolved Hide resolved
Thank you in the future I will definitely use "allow-all"

Co-authored-by: Akash Ganapathi <[email protected]>
I continue to learn from this exercise thank you.

Co-authored-by: Akash Ganapathi <[email protected]>
Copy link

@chjlarson chjlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the verbiage accurate is important to keep it clear and concise. Having “allow-all” access may not always be the same as access that allows all (this would be the case for a misconfiguration)

The simplification from * should allow for a better run time

Looks good! No obvious syntax errors! Should run just fine

@mcpeach9 mcpeach9 requested a review from VDubber August 19, 2022 22:44
Copy link
Author

@mcpeach9 mcpeach9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacob-dowdy modified the query to reflect single property disablePasswordAuthentication
TIA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants