This repository has been archived by the owner on Sep 3, 2024. It is now read-only.
APP-15543 - Use createIntegrationHelpers #659
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzolo22
commented
Aug 6, 2024
Comment on lines
85
to
92
| public: SchemaType.Boolean({ | ||
| description: | ||
| 'This value is not applicable to this entity, however is expected on a entity with a _class of `Network`', | ||
| default: false, | ||
| }), | ||
| internal: SchemaType.Boolean({ | ||
| description: | ||
| 'This value is not applicable to this entity, however is expected on a entity with a _class of `Network`', |
There was a problem hiding this comment.
Not necessarily thrilled with this but couldn't think of a better way to handle
jzolo22
added
minor
jzolo22
commented
Sep 3, 2024
Comment on lines
+123
to
+126
| public: false, | ||
| internal: false, | ||
| CIDR: null, | ||
| }), |
There was a problem hiding this comment.
Same with comment below - not sure this is the best way to handle these required properties...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.