Add Device and Users Steps #2

zemberdotnet · 2023-03-03T15:25:57Z

Description

Adding Device and Users steps to integration

Type of change

Please leave any irrelevant options unchecked.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to
not work as expected)
This change requires a documentation update

Checklist

General Development Checklist:

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

I have checked for additional permissions required to call any new API
endpoints, and have documented any additional permissions in
jupiterone.md, where necessary.
My changes properly paginate the target service provider's API
My changes properly handle rate limiting of the target service provider's
API
My new integration step is instrumented to execute in the correct order
using dependsOn
I have referred to the
JupiterOne data model
to ensure that any new entities/relationships, and relevant properties,
match the recommended model for this class of data
I have updated the CHANGELOG.md file to describe my changes
When changes include modifications to existing graph data ingestion, I've
reviewed all existing managed questions referencing the entities,
relationships, and their property names, to ensure those questions still
function with my changes.

src/client.ts

src/config.ts

src/steps/end-users/converters.ts

VDubber

Few minor comments.

VDubber · 2023-03-06T17:00:05Z

It'd be good to get account entity added and then a mapping in data-dictionary to root.

VDubber · 2023-03-06T20:36:49Z

test/config.ts


 export const integrationConfig: IntegrationConfig = {
-  clientId: process.env.CLIENT_ID || DEFAULT_CLIENT_ID,
-  clientSecret: process.env.CLIENT_SECRET || DEFAULT_CLIENT_SECRET,
+  device42Username: process.env.USERNAME || 'test',


Update USERNAME reference here too

nit: consider using ?? instead of logical OR ||

Updated here as well. I completely missed it!

src/validateInvocation.test.ts

test/config.ts

zemberdotnet added 4 commits March 2, 2023 16:26

add gaxios dependency and update config

0a1c557

feat: add device and end user steps

391659b

add retry logic to client

f51ab33

return empty promise in verifyAuth

4824760