Merge pull request #225 from JupiterOne/INT-11046

Int 11046
JupiterOne-Archives · May 29, 2024 · bb288ad · bb288ad
2 parents 1f05f98 + 6cdacd6
commit bb288ad
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/src/steps/groups/__snapshots__/converters.test.ts.snap b/src/steps/groups/__snapshots__/converters.test.ts.snap
@@ -13,6 +13,7 @@ Object {
         "adminCreated": true,
         "aliases": Array [
           "[email protected]",
+          "[email protected]",
         ],
         "description": "[email protected] distribution list",
         "directMembersCount": "5",
@@ -29,6 +30,10 @@ Object {
   ],
   "_type": "google_group",
   "adminCreated": true,
+  "aliases": Array [
+    "[email protected]",
+    "[email protected]",
+  ],
   "createdOn": undefined,
   "description": "[email protected] distribution list",
   "directMembersCount": "5",
@@ -37,6 +42,9 @@ Object {
   "id": "0184mhaj0imamcg",
   "kind": "admin#directory#group",
   "name": "Random",
+  "nonEditableAliases": Array [
+    "[email protected]",
+  ],
 }
 `;
 

diff --git a/src/steps/groups/__snapshots__/index.test.ts.snap b/src/steps/groups/__snapshots__/index.test.ts.snap
@@ -663,6 +663,7 @@ Object {
       ],
       "_type": "google_group",
       "adminCreated": true,
+      "aliases": undefined,
       "createdOn": undefined,
       "description": "Developers on JupiterOne integrations team",
       "directMembersCount": "3",
@@ -671,6 +672,9 @@ Object {
       "id": "023ckvvd4kecvcb",
       "kind": "admin#directory#group",
       "name": "Integration Developers",
+      "nonEditableAliases": Array [
+        "[email protected]",
+      ],
     },
     Object {
       "_class": Array [
@@ -697,6 +701,7 @@ Object {
       ],
       "_type": "google_group",
       "adminCreated": true,
+      "aliases": undefined,
       "createdOn": undefined,
       "description": "",
       "directMembersCount": "0",
@@ -705,6 +710,9 @@ Object {
       "id": "00sqyw643dnjpsf",
       "kind": "admin#directory#group",
       "name": "OverlappingEmailTest1",
+      "nonEditableAliases": Array [
+        "[email protected]",
+      ],
     },
     Object {
       "_class": Array [
@@ -731,6 +739,7 @@ Object {
       ],
       "_type": "google_group",
       "adminCreated": true,
+      "aliases": undefined,
       "createdOn": undefined,
       "description": "Test additional group",
       "directMembersCount": "1",
@@ -739,6 +748,9 @@ Object {
       "id": "03cqmetx36hgkxw",
       "kind": "admin#directory#group",
       "name": "TestExtraGroup",
+      "nonEditableAliases": Array [
+        "[email protected]",
+      ],
     },
     Object {
       "_class": Array [

diff --git a/src/steps/groups/converters.test.ts b/src/steps/groups/converters.test.ts
@@ -23,7 +23,7 @@ function getMockGroup(
     directMembersCount: '5',
     description: '[email protected] distribution list',
     adminCreated: true,
-    aliases: ['[email protected]'],
+    aliases: ['[email protected]', '[email protected]'],
     nonEditableAliases: ['[email protected]'],
     ...partial,
   };

diff --git a/src/steps/groups/converters.ts b/src/steps/groups/converters.ts
@@ -38,6 +38,8 @@ export function createGroupEntity(data: admin_directory_v1.Schema$Group) {
         kind: data.kind,
         name: data.name,
         description: data.description,
+        aliases: data.aliases,
+        nonEditableAliases: data.nonEditableAliases,
       },
     },
   });