Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

INT-3834 - HackerOne Asset Entity Created and Add Mapped Relationship to Findings #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eXtremeX
Copy link

Description

Thank you for contributing to a JupiterOne integration!

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Summary

  • We'd like to hear ideas about class that should be used for PROGRAM_ASSET entity, since it was mentioned in the ticket that it shouldn't be Asset nor Record.

Example program asset sample response:

{
  id: '274636',
  type: 'structured-scope',
  attributes: {
    asset_type: 'URL',
    asset_identifier: 'blog.jupiterone.com',
    eligible_for_bounty: false,
    eligible_for_submission: false,
    instruction: null,
    max_severity: 'none',
    created_at: '2022-12-06T06:48:25.623Z',
    updated_at: '2022-12-06T06:48:25.623Z',
    reference: null
  }
}

Type of change

Please leave any irrelevant options unchecked.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

General Development Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

  • I have checked for additional permissions required to call any new API
    endpoints, and have documented any additional permissions in
    jupiterone.md, where necessary.
  • My changes properly paginate the target service provider's API
  • My changes properly handle rate limiting of the target service provider's
    API
  • My new integration step is instrumented to execute in the correct order
    using dependsOn
  • I have referred to the
    JupiterOne data model
    to ensure that any new entities/relationships, and relevant properties,
    match the recommended model for this class of data
  • I have updated the CHANGELOG.md file to describe my changes
  • When changes include modifications to existing graph data ingestion, I've
    reviewed all existing managed questions referencing the entities,
    relationships, and their property names, to ensure those questions still
    function with my changes.

@eXtremeX eXtremeX requested a review from a team January 27, 2023 05:05
@eXtremeX eXtremeX requested a review from a team as a code owner January 27, 2023 05:05
@socket-security
Copy link

socket-security bot commented Feb 6, 2023

Socket Security Pull Request Report

👍 No new dependency issues detected in pull request

Pull request report summary
Issue Status
Critical CVE ✅ 0 issues
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
AI detected malware ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

export function capitalize(
sentence: string | undefined | null,
): string | undefined {
if (sentence == undefined || sentence == null) {

Check notice

Code scanning / CodeQL

Unneeded defensive code

This guard always evaluates to false.
@eXtremeX eXtremeX force-pushed the feature/int-3834-asset-findings branch from a978171 to 8367ed4 Compare February 14, 2023 12:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants