Skip to content
This repository has been archived by the owner on Aug 8, 2024. It is now read-only.

use base api client #26

Merged
merged 3 commits into from
Aug 6, 2024
Merged

use base api client #26

merged 3 commits into from
Aug 6, 2024

Conversation

RonaldEAM
Copy link
Contributor

Description

Thank you for contributing to a JupiterOne integration!

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.

Summary

Type of change

Please leave any irrelevant options unchecked.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

Checklist

General Development Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Integration Development Checklist:

Please leave any irrelevant options unchecked.

  • I have checked for additional permissions required to call any new API
    endpoints, and have documented any additional permissions in
    jupiterone.md, where necessary.
  • My changes properly paginate the target service provider's API
  • My changes properly handle rate limiting of the target service provider's
    API
  • My new integration step is instrumented to execute in the correct order
    using dependsOn
  • I have referred to the
    JupiterOne data model
    to ensure that any new entities/relationships, and relevant properties,
    match the recommended model for this class of data
  • I have updated the CHANGELOG.md file to describe my changes
  • When changes include modifications to existing graph data ingestion, I've
    reviewed all existing managed questions referencing the entities,
    relationships, and their property names, to ensure those questions still
    function with my changes.

@RonaldEAM RonaldEAM requested a review from a team as a code owner August 5, 2024 22:54
Copy link

socket-security bot commented Aug 5, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jupiterone/[email protected] None 0 18.3 kB jupiterone-dev
npm/@jupiterone/[email protected] None 0 240 kB jupiterone-dev
npm/[email protected] network 0 162 kB node-fetch-bot

🚮 Removed packages: npm/[email protected]

View full report↗︎

@RonaldEAM RonaldEAM merged commit 9c8b960 into main Aug 6, 2024
7 of 8 checks passed
@RonaldEAM RonaldEAM deleted the INT-11357-use-base-client branch August 6, 2024 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants