Skip to content

Commit

Permalink
manual-e2e-run -- cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jablonnc committed Oct 27, 2023
1 parent 7d3054e commit 53624c5
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/docs/frontend/frontend_npm_pr.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Default flow for an NPM package when a PR is opened

This is the [default workflow](../../frontend_npm_pr.yml@v#) that is run when a `PR is opened` for an `npm package`. It is meant to test the quality and safety of the code being committed.
This is the [default workflow](../../frontend_npm_pr.yml) that is run when a `PR is opened` for an `npm package`. It is meant to test the quality and safety of the code being committed.

## Inputs

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs/frontend/frontend_npm_release.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Default flow for an NPM package when its merged to mai

This is the [default workflow](../../frontend_npm_release.yml@v#) that is run when a `PR is merged to main` for an `npm package`. It is meant to release the package and capture information in Cortex related to the package.
This is the [default workflow](../../frontend_npm_release.yml) that is run when a `PR is merged to main` for an `npm package`. It is meant to release the package and capture information in Cortex related to the package.

## Inputs

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Default workflow for a runtime application when a PR is opened
# Default workflow for running E2E tests when a PR comment is left


This is the [default workflow](../../frontend_runtime_application_pr.yml@v#) that is run when a `PR is opened` for an `application runtime`. It is meant to test the quality and safety of the code being committed.
This is the [default workflow](../../frontend_runtime_application_manual_e2e_run.yml) that is leveraged to trigger E2E tests for for an `application runtime`. Specifically, when a PR is opened and a comment of `/run-e2e-tests` is left, it will trigger an E2E test run.

## Inputs

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Default workflow for a runtime application when a PR is opened


This is the [default workflow](../../frontend_runtime_application_pr.yml@v#) that is run when a `PR is opened` for an `application runtime`. It is meant to test the quality and safety of the code being committed.
This is the [default workflow](../../frontend_runtime_application_pr.yml) that is run when a `PR is opened` for an `application runtime`. It is meant to test the quality and safety of the code being committed.

## Inputs

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs/frontend/frontend_runtime_deploy.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Frontend Runtime Deploy


This is the [default workflow](../../frontend_runtime_application_pr.yml@v#) that is run when a `PR is merged to main` for a `runtime`.
This is the [default workflow](../../frontend_runtime_application_pr.yml) that is run when a `PR is merged to main` for a `runtime`.

**NOTE:** Our current workflow mostly goes through Jenkins at the moment. However the long term goal is to transition our entire deploy flow to Github actions, where the following flow becomes single source of truth.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# PR flow running E2E tests when triggered by an external repo

This is the [default workflow](../../frontend_runtime_application_pr.yml@v#) that is run when E2E tests are triggered by an external repo.
This is the [default workflow](../../frontend_runtime_application_pr.yml) that is run when E2E tests are triggered by an external repo.

## Inputs

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Default workflow for a runtime application when a PR is opened


This is the [default workflow](../../frontend_runtime_application_pr.yml@v#) that is run when a `PR is opened` for a `utility runtime`. It is meant to test the quality and safety of the code being committed.
This is the [default workflow](../../frontend_runtime_application_pr.yml) that is run when a `PR is opened` for a `utility runtime`. It is meant to test the quality and safety of the code being committed.

## Inputs

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ jobs:
auto_cancel_after_failures: ${{ inputs.auto_cancel_after_failures }}

e2e_status:
# if: github.event.issue.pull_request && contains(github.event.comment.body, '/run-e2e-tests')
name: E2E Status
runs-on: ${{ (inputs.fallback_runner && 'ubuntu-latest') || 'scaleset-jupiterone-infra-arm64' }}
needs: [e2e_pending_status, e2e_run]
Expand Down

0 comments on commit 53624c5

Please sign in to comment.