SRE-1276 Promote docker images composite action #153
Conversation
| docker pull ${{ inputs.source_account_id }}.dkr.ecr.${{ inputs.source_region }}.amazonaws.com/${{ inputs.image_name }}:$tag | ||
| done | ||
| - name: bootstrap_target_ecr_registry | ||
| uses: jupiterone/provision-cortex/.github/actions/create_ecr_repo@SRE-1479 |
There was a problem hiding this comment.
Do we have a ticket or some kind of reminder to ensure this gets updated once this work has been elevated?
There was a problem hiding this comment.
I just went ahead and updated it now since this action wont work until that gets merged in anyway.
| image_names: ${{ inputs.image_name }} | ||
| project_name: ${{ inputs.project_name }} | ||
| target_environment: ${{ inputs.target_environment }} | ||
| - name: configurate_target_account_aws_credentials |
There was a problem hiding this comment.
configurate_target_account_aws_credentials -> configure_target_account_aws_credentials
There was a problem hiding this comment.
you ain't ne'er heard of configuratin', boy?
Updated
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: configurate_source_account_aws_credentials |
There was a problem hiding this comment.
configurate_source_account_aws_credentials -> configure_source_account_aws_credentials
| @@ -0,0 +1,33 @@ | |||
| import { MockGithub } from '@kie/mock-github'; | |||
There was a problem hiding this comment.
So as this test shows, there's nothing to really test here. In this case I think we'd be better served deleting this tests as it really offers no value.
There was a problem hiding this comment.
Alright cool I just left in in place in case we wanted to extend it later but may as well just remove it altogether.
Composite action to copy a source image typically from Infra to the deployment destination account registry. Many of these inputs may not be necessary in the context of a complete workflow, but added them for now anyway so that the action could be tested and is relatively self-contained.
In addition to limited unit testing, tested manually (as much as possible) in the following pipeline: https://github.com/JupiterOne/provision-cortex/actions/runs/7061537740/job/19228891765